Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fish completions): quote short options too #5503

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lolbinarycat
Copy link

this should make things a bit easier for any programs that want to make '-?' an alias for '--help'

this should make things a bit easier for any programs that want to
make '-?' an alias for '--help'

this is a bit more complex than initially anticipated, since
the unit tests expect output to be bit-identical.
@epage
Copy link
Member

epage commented May 23, 2024

Can you add a test case that demonstrates the problem?

Ideally, the test case would apply to all shells and be in its own commit, showing the current behavior. Your current commit would then be on top and would then include test updates.

Separating the test from the fix makes it so the fix commit demonstrates in action what the change of behavior is and helps test-the-test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants