BAC-296: update Client.Evaluate call to version 1.2alpha1 (breaking)
#34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smyrman
reviewed
Jan 19, 2024
smyrman
reviewed
Jan 19, 2024
smyrman
reviewed
Jan 19, 2024
smyrman
reviewed
Jan 19, 2024
|
thank you sindre, i'll be back with something corrected |
magnusgohn
force-pushed
the
magnus/evaluate
branch
3 times, most recently
from
947ad27
to
1058855
Compare
magnusgohn
force-pushed
the
magnus/evaluate
branch
from
495e64a
to
e324b40
Compare
smyrman
reviewed
Jan 22, 2024
magnusgohn
force-pushed
the
magnus/evaluate
branch
from
e324b40
to
4c9a9c4
Compare
|
Split in two documents, but try to follow this commit-style: E.g. In PR title, add issue prefix: For this case, there is no (sub-component) prefix needed. |
magnusgohn
force-pushed
the
magnus/evaluate
branch
3 times, most recently
from
ad74157
to
5e45f98
Compare
magnusgohn
changed the title
Evaluate call to version 1.2alpha1 (breaking)
magnusgohn
changed the title
Evaluate call to version 1.2alpha1 (breaking)Client.Evaluate call to version 1.2alpha1 (breaking)
magnusgohn
force-pushed
the
magnus/evaluate
branch
from
5e45f98
to
2e9cc8a
Compare
this introduces a breaking change in `Evaluate` requiring users of
this function to update as follows:
```
Evaluate(items, calculations, data)
↓
Evaluate(data).
Items(items...).
Calculations(calculations...)
```
the type `AggregateMethod` has been updated as follows:
```
AggregateMethod → TimeAggregationMethod
```
with new value names:
```
AggregateDefault → TimeAggregationDefault
AggregateCount → TimeAggregationCount
AggregateMin → TimeAggregationMin
AggregateMax → TimeAggregationMax
AggregateSum → TimeAggregationSum
AggregateAvg → TimeAggregationAvg
AggregateStateHistSeconds → TimeAggregationSeconds
AggregateStateHistPercent → TimeAggregationPercent
AggregateStateHistRate → TimeAggregationRate
```
the type `ItemAggregation` has been updated as follows:
```
ItemAggregation → EvaluateItem
```
magnusgohn
force-pushed
the
magnus/evaluate
branch
from
2e9cc8a
to
b0b1451
Compare
smyrman
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i have updated the clarify go sdk to support the new
evaluateparametergroups. i have also updated some names to match the changes introduced in BAC-282. lastly i have updated theautomationandexamplespackages to use the new builder styleEvaluateRequesttype