Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BAC-305 added integration tests #36

Merged
merged 1 commit into from
Mar 22, 2024
Merged

BAC-305 added integration tests #36

merged 1 commit into from
Mar 22, 2024

Conversation

magnusgohn
Copy link
Collaborator

@magnusgohn magnusgohn commented Feb 12, 2024 •
edited
Loading

added integration tests for the following methods:

  • admin.publishSignals
  • admin.selectSignals
  • clarify.dataFrame
  • clarify.evaluate
  • clarify.selectItems
  • integration.insert
  • integration.saveSignals

in addition i performed the following minor fixes:

  • added a missing Location field to EvaluateRequest
  • fixed Include not being included when performing an EvaluateRequest
  • fixed EvaluateGroup always dismissing the State value provided

@magnusgohn magnusgohn closed this Feb 12, 2024
@magnusgohn magnusgohn reopened this Feb 12, 2024
@magnusgohn magnusgohn closed this Feb 12, 2024
@magnusgohn magnusgohn reopened this Feb 12, 2024
@magnusgohn magnusgohn force-pushed the magnus/integration-test branch 8 times, most recently from d957afa to 3b66eb1 Compare February 14, 2024 07:52
@magnusgohn magnusgohn changed the title added integration tests BAC-305 added integration tests Feb 14, 2024
@magnusgohn magnusgohn marked this pull request as ready for review February 15, 2024 09:22
@magnusgohn magnusgohn self-assigned this Feb 15, 2024
smyrman
smyrman requested changes Feb 16, 2024
View reviewed changes
test/common.go Outdated Show resolved Hide resolved
.github/workflows/go.yml Outdated Show resolved Hide resolved
test/common.go Outdated Show resolved Hide resolved
test/evaluate_integration_test.go Outdated Show resolved Hide resolved
test/evaluate_integration_test.go Outdated Show resolved Hide resolved
test/evaluate_integration_test.go Outdated Show resolved Hide resolved
test/insert_integration_test.go Show resolved Hide resolved
test/common.go Outdated Show resolved Hide resolved
smyrman
smyrman reviewed Feb 16, 2024
View reviewed changes
test/common.go Outdated Show resolved Hide resolved
smyrman
smyrman reviewed Feb 16, 2024
View reviewed changes
test/common.go Outdated Show resolved Hide resolved
@magnusgohn magnusgohn force-pushed the magnus/integration-test branch 6 times, most recently from 9ed3f1b to f18c112 Compare February 26, 2024 13:05
smyrman
smyrman reviewed Mar 21, 2024
View reviewed changes
test/common.go Outdated Show resolved Hide resolved
smyrman
smyrman reviewed Mar 21, 2024
View reviewed changes
Copy link
Contributor

@smyrman smyrman left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor issues, otherwise I am mostly happy with this.

test/evaluate_integration_test.go Outdated Show resolved Hide resolved
test/evaluate_integration_test.go Outdated Show resolved Hide resolved
@magnusgohn magnusgohn requested a review from smyrman March 21, 2024 11:45
smyrman
smyrman reviewed Mar 21, 2024
View reviewed changes
test/common.go Outdated Show resolved Hide resolved
smyrman
smyrman approved these changes Mar 21, 2024
View reviewed changes
Copy link
Contributor

@smyrman smyrman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly OK; nice if you fix the remaining comments, but after that I am OK with merging this.

test/publish_signals_integration_test.go Outdated Show resolved Hide resolved
test/publish_signals_integration_test.go Outdated Show resolved Hide resolved
@magnusgohn magnusgohn marked this pull request as ready for review March 22, 2024 17:44
@magnusgohn magnusgohn merged commit 22c3e34 into main Mar 22, 2024
2 checks passed
@magnusgohn magnusgohn deleted the magnus/integration-test branch March 22, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smyrman smyrman smyrman approved these changes

Assignees

@magnusgohn magnusgohn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@magnusgohn @smyrman