Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lacking tabs event listeners #128

Closed
wants to merge 3 commits into from
Closed

Add lacking tabs event listeners #128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
093665e
Add lacking tabs event listeners
softoika Oct 28, 2020
40ce9c5
Merge branch 'master' into tabs-events
Oct 28, 2020
375a44f
Merge branch 'master' into tabs-events
Oct 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 20 additions & 7 deletions __tests__/tabs.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,13 +94,26 @@ describe('browser.tabs', () => {
{ id: 3, pinned: true },
]);
});
['addListener', 'removeListener', 'hasListener'].forEach((method) => {
test(`onUpdated.${method}`, () => {
const callback = jest.fn();
expect(jest.isMockFunction(browser.tabs.onUpdated[method])).toBe(true);
browser.tabs.onUpdated[method](callback);
expect(browser.tabs.onUpdated[method]).toHaveBeenCalledTimes(1);
expect(callback).toHaveBeenCalledTimes(0);
[
'onCreated',
'onUpdated',
'onMoved',
'onActivated',
'onHighlighted',
'onDetached',
'onAttached',
'onRemoved',
'onReplaced',
'onZoomChange',
].forEach((event) => {
['addListener', 'removeListener', 'hasListener'].forEach((method) => {
test(`${event}.${method}`, () => {
const callback = jest.fn();
expect(jest.isMockFunction(browser.tabs[event][method])).toBe(true);
browser.tabs[event][method](callback);
expect(browser.tabs[event][method]).toHaveBeenCalledTimes(1);
expect(callback).toHaveBeenCalledTimes(0);
});
});
});
test('reload', (done) => {
Expand Down
156 changes: 107 additions & 49 deletions dist/setup.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,64 @@ var omnibox = {
}
};

var onMessageListeners = [];
var runtime = {
connect: jest.fn(function (_ref) {
var name = _ref.name;
return {
name: name,
postMessage: jest.fn(),
onDisconnect: {
addListener: jest.fn()
},
onMessage: {
addListener: jest.fn(function (listener) {
onMessageListeners.push(listener);
})
},
disconnect: jest.fn()
};
}),
sendMessage: jest.fn(function (message, cb) {
onMessageListeners.forEach(function (listener) {
return listener(message);
});

if (cb !== undefined) {
return cb();
}

return Promise.resolve();
}),
onMessage: {
addListener: jest.fn(function (listener) {
onMessageListeners.push(listener);
}),
removeListener: jest.fn(function (listener) {
onMessageListeners = onMessageListeners.filter(function (lstn) {
return lstn !== listener;
});
}),
hasListener: jest.fn(function (listener) {
return onMessageListeners.includes(listener);
})
},
onConnect: {
addListener: jest.fn(),
removeListener: jest.fn(),
hasListener: jest.fn()
},
onInstalled: {
addListener: jest.fn(),
removeListener: jest.fn(),
hasListener: jest.fn()
},
getURL: jest.fn(function (path) {
return path;
}),
openOptionsPage: jest.fn()
};

// https://developer.chrome.com/extensions/tabs
var tabs = {
get: jest.fn(function () {
Expand Down Expand Up @@ -92,70 +150,70 @@ var tabs = {
});
}));
}),
onCreated: {
addListener: jest.fn(),
removeListener: jest.fn(),
hasListener: jest.fn()
},
onUpdated: {
addListener: jest.fn(),
removeListener: jest.fn(),
hasListener: jest.fn()
},
sendMessage: jest.fn()
};

var onMessageListeners = [];
var runtime = {
connect: jest.fn(function (_ref) {
var name = _ref.name;
return {
name: name,
postMessage: jest.fn(),
onDisconnect: {
addListener: jest.fn()
},
onMessage: {
addListener: jest.fn(function (listener) {
onMessageListeners.push(listener);
})
},
disconnect: jest.fn()
};
}),
sendMessage: jest.fn(function (message, cb) {
onMessageListeners.forEach(function (listener) {
return listener(message);
});

if (cb !== undefined) {
return cb();
}

return Promise.resolve();
}),
onMessage: {
addListener: jest.fn(function (listener) {
onMessageListeners.push(listener);
}),
removeListener: jest.fn(function (listener) {
onMessageListeners = onMessageListeners.filter(function (lstn) {
return lstn !== listener;
});
}),
hasListener: jest.fn(function (listener) {
return onMessageListeners.includes(listener);
})
onMoved: {
addListener: jest.fn(),
removeListener: jest.fn(),
hasListener: jest.fn()
},
onConnect: {
onActivated: {
addListener: jest.fn(),
removeListener: jest.fn(),
hasListener: jest.fn()
},
onInstalled: {
onHighlighted: {
addListener: jest.fn(),
removeListener: jest.fn(),
hasListener: jest.fn()
},
getURL: jest.fn(function (path) {
return path;
onDetached: {
addListener: jest.fn(),
removeListener: jest.fn(),
hasListener: jest.fn()
},
onAttached: {
addListener: jest.fn(),
removeListener: jest.fn(),
hasListener: jest.fn()
},
onRemoved: {
addListener: jest.fn(),
removeListener: jest.fn(),
hasListener: jest.fn()
},
onReplaced: {
addListener: jest.fn(),
removeListener: jest.fn(),
hasListener: jest.fn()
},
onZoomChange: {
addListener: jest.fn(),
removeListener: jest.fn(),
hasListener: jest.fn()
},
sendMessage: jest.fn(function (tabId, message, cb) {
onMessageListeners.forEach(function (listener) {
return listener(tabId, message);
});

if (cb !== undefined) {
return cb();
}

return Promise.resolve();
}),
openOptionsPage: jest.fn()
reload: jest.fn(function (tabId, reloadProperties, cb) {
return cb();
})
};

function _typeof(obj) {
Expand Down
45 changes: 45 additions & 0 deletions src/tabs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,11 +40,56 @@ export const tabs = {
move: jest.fn((ids = [], props = {}, cb = () => {}) =>
cb(ids.map((id) => Object.assign({}, props, { id })))
),
onCreated: {
addListener: jest.fn(),
removeListener: jest.fn(),
hasListener: jest.fn(),
},
onUpdated: {
addListener: jest.fn(),
removeListener: jest.fn(),
hasListener: jest.fn(),
},
onMoved: {
addListener: jest.fn(),
removeListener: jest.fn(),
hasListener: jest.fn(),
},
onActivated: {
addListener: jest.fn(),
removeListener: jest.fn(),
hasListener: jest.fn(),
},
onHighlighted: {
addListener: jest.fn(),
removeListener: jest.fn(),
hasListener: jest.fn(),
},
onDetached: {
addListener: jest.fn(),
removeListener: jest.fn(),
hasListener: jest.fn(),
},
onAttached: {
addListener: jest.fn(),
removeListener: jest.fn(),
hasListener: jest.fn(),
},
onRemoved: {
addListener: jest.fn(),
removeListener: jest.fn(),
hasListener: jest.fn(),
},
onReplaced: {
addListener: jest.fn(),
removeListener: jest.fn(),
hasListener: jest.fn(),
},
onZoomChange: {
addListener: jest.fn(),
removeListener: jest.fn(),
hasListener: jest.fn(),
},
sendMessage: jest.fn((tabId, message, cb) => {
onMessageListeners.forEach((listener) => listener(tabId, message));
if (cb !== undefined) {
Expand Down