Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Ethernet core #8
base: main
Are you sure you want to change the base?
Add Ethernet core #8
Changes from 5 commits
0c59cff
9cf12fd
b89f52e
669673f
a73282a
29d774d
a3c4a6f
60cd05b
270e582
44626b8
3b031f2
52a3f2d
039aa9e
69f8944
903707e
815b19c
3acdaff
2658307
c70dc3b
4b5be3f
bd518d3
e5dd967
5c6df09
3b2af77
7e7c464
c86dcfb
bb0c3f0
a1ddf8b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't get why this
_awaitTransmission
is necessary? If you are in theAwaitLookup
state and you receive aJust lookupIPv4
why can't you just forward that directly to the ARP table?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do forward the IP address unconditionally?
_awaitTransmission
is needed to be able to keep driving the same ARP request to the transmitter if the transmitter asserts backpressure.It makes no difference for a single entry ARP table which has one clock cycle latency, which is why the old version worked in hardware. But with a multi-entry table you can have a longer latency. And that's where the notorious bug that stopped the multi-entry stack from working came from.
I.e. it sent an ARP request to the transmitter, the transmitter did nothing with it because he wasn't ready, but we already moved to the waiting state.