-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tuple instances for Simulate
, Drivable
, Backpressure
and Test
#117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmbollen
force-pushed
the
lucas/simulate-tuple-instances
branch
3 times, most recently
from
November 19, 2024 08:03
f5eac45
to
28173f2
Compare
lmbollen
force-pushed
the
lucas/add-drivable-tuples
branch
from
November 19, 2024 08:23
17e4ea5
to
997b83f
Compare
lmbollen
changed the base branch from
lucas/simulate-tuple-instances
to
main
November 19, 2024 08:25
lmbollen
changed the title
Add tuple instances for
Add tuple instances for Nov 19, 2024
Drivable
and Backpressure
Simulate
, Drivable
and Backpressure
lmbollen
requested review from
DigitalBrains1,
martijnbastiaan and
rowanG077
November 19, 2024 08:28
lmbollen
force-pushed
the
lucas/add-drivable-tuples
branch
from
November 20, 2024 08:35
997b83f
to
78101ea
Compare
martijnbastiaan
approved these changes
Nov 20, 2024
rowanG077
approved these changes
Nov 20, 2024
lmbollen
changed the title
Add tuple instances for
Add tuple instances for Nov 20, 2024
Simulate
, Drivable
and Backpressure
Simulate
, Drivable
, Backpressure
and Test
lmbollen
force-pushed
the
lucas/add-drivable-tuples
branch
5 times, most recently
from
November 20, 2024 13:41
bf975bc
to
7380f15
Compare
DigitalBrains1
previously requested changes
Nov 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You forgot a backtick in the commit summary:
Move
BackPressure
,Simulate
,Drivable
and `Test
lmbollen
force-pushed
the
lucas/add-drivable-tuples
branch
2 times, most recently
from
November 20, 2024 15:47
e0fe489
to
a2de530
Compare
To prevent cyclic dependencies when implementing TH functions that generate tuple instances for these typeclasses.
Includes tuple instances of `Test` up to 9 tuples
lmbollen
force-pushed
the
lucas/add-drivable-tuples
branch
from
November 20, 2024 16:13
a2de530
to
e1d09b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To allow simulating tuples of circuits