Move Documentation check to separate job #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmbollen
force-pushed
the
ci-documentation-job
branch
from
95b1bb5 to
16f505d
Compare
martijnbastiaan
requested changes
May 16, 2024
.github/workflows/ci.yml
Outdated
|
|
||
| - name: Build | ||
| run: | | ||
| .ci/build_docs.sh -clash_version 9.6.4 |
There was a problem hiding this comment.
Suggested change
| .ci/build_docs.sh -clash_version 9.6.4 | |
| .ci/build_docs.sh --clash_version 9.6.4 |
lmbollen
force-pushed
the
ci-documentation-job
branch
4 times, most recently
from
bf9df64 to
76368a3
Compare
martijnbastiaan
requested changes
May 16, 2024
.github/workflows/ci.yml
Outdated
| @@ -125,3 +121,14 @@ jobs: | |||
| - name: Whitespace | |||
| run: | | |||
| .ci/test_whitespace.sh | |||
|
|
|||
| documentation: | |||
| name: Documentation clash_version 9.6.4 | |||
There was a problem hiding this comment.
Suggested change
| name: Documentation clash_version 9.6.4 | |
| name: Documentation |
9.6.4 => GHC version. But also, it's fine to not mention it in the CI job name anyway.
There was a problem hiding this comment.
Also also, why are we setting Clash's version exactly?
There was a problem hiding this comment.
Good question, I'm removing it entirely
lmbollen
force-pushed
the
ci-documentation-job
branch
7 times, most recently
from
3fa467d to
403b98a
Compare
Currently all cabal tests can fail due to missing documentation, this is undesirable since we can no more distinguish ghc / clash version related problems if documentation does not build
lmbollen
force-pushed
the
ci-documentation-job
branch
from
403b98a to
8f2a9db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently all cabal tests can fail due to missing documentation, this is undesirable since we can not distinguish ghc / clash version related problems from missing documentation failures.