Add test for vexriscv reset behavior #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martijnbastiaan
force-pushed
the
in-reset-behavior-tests
branch
2 times, most recently
from
388e613 to
5d37117
Compare
hiddemoll
approved these changes
Feb 13, 2025
martijnbastiaan
force-pushed
the
in-reset-behavior-tests
branch
3 times, most recently
from
5011bd3 to
1b343a9
Compare
Turns out, the chain works just fine with one CPU in reset, which is the behavior we want and expect. This commit also factors out some of the shared code between the tests to keep it a bit more manageable.
martijnbastiaan
force-pushed
the
in-reset-behavior-tests
branch
from
1b343a9 to
45ee942
Compare
martijnbastiaan
force-pushed
the
in-reset-behavior-tests
branch
4 times, most recently
from
c640ae8 to
cb08e66
Compare
lmbollen
approved these changes
Feb 19, 2025
|
@leonschoorl suggested completely restarting OpenOCD to get around the unreliable tests. This seems to work from an OpenOCD/GDB perspective, but then again breaks on some other problem with the remote bitbang implementation. I'm out of time for this one, so I'm dropping it.. |
Makes output much more useful if something goes wrong
martijnbastiaan
force-pushed
the
in-reset-behavior-tests
branch
from
cb08e66 to
6a17a3d
Compare
|
@lmbollen I've renamed |
martijnbastiaan
force-pushed
the
in-reset-behavior-tests
branch
from
6a17a3d to
6783596
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds two tests:
There is also a test that tests whether we can assert the reset while GDB is doing things and expect it to recover... but it can't reliably. I've disabled the test with an
-- XXX: ....in hopes we can find a way to properly recover in the future.