Variable picker #92
Merged
Variable picker #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…igger reactive behaviour downstream in solidjs
…changing the props
sverhoeven
reviewed
Jan 6, 2025
| @@ -28,6 +46,11 @@ const linestyles = ["none", "5,5", "10,10", "15,5,5,5", "20,10,5,5,5,10"]; | |||
| * It only works if the time axes are equal | |||
| */ | |||
| export function TimeSeriesPlot() { | |||
| const [xVariable, setXVariable] = createSignal("t"); | |||
| const [yVariable, setYVariable] = createSignal("theta"); | |||
There was a problem hiding this comment.
When saving/restoring a session or sharing a link would it make sense to also store the variable selection?
If so we would need to lift those signals to the analyses store.
There was a problem hiding this comment.
I think that would make sense in the future, so I have done as you suggested. Variables are now set in the store. Regarding the URL, I think we should wait for the analysis interface to stabilize, so we can add it later.
I agree, but I always struggle to write test for "figure should look different". I'm not eager to spend a lot of time on that now. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a variable picker for profiles and timeseries plots
TODO: