improve signal handling so that it exits gracefully #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fenrir-naru
added a commit
to fenrir-naru/rinruby
that referenced
this pull request
Aug 28, 2018
* clbustos#17 is included (restoring original INT handler)
fenrir-naru
added a commit
to fenrir-naru/rinruby
that referenced
this pull request
Aug 29, 2018
* clbustos#17 is included (restoring original INT handler) * TODO: I18N (multi-byte string)
fenrir-naru
added a commit
to fenrir-naru/rinruby
that referenced
this pull request
Aug 29, 2018
* clbustos#17 is included (restoring original INT handler) * TODO: I18N (multi-byte string)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it was often difficult to kill a rails server if rinruby had run. Rinruby would trap INT and do nothing, effectively preventing a user from canceling a running server.
The concept of these changes is to reset the trap to its original state after the trap established by rinruby is no longer needed. I'm not sure this is correct.
Thank you.