Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fallback exception when double quotes are used - see issue #19 #20

Merged

Conversation

mrchrisadams
Copy link
Contributor

@mrchrisadams mrchrisadams commented Jul 19, 2023

This is a WIP PR for adding a fallback when people use datasette and accidentally use double quotes when wrapping literal values, which DuckDB has a problem with.

For more, see issue #19

@mrchrisadams mrchrisadams changed the title WIP: Add fallback exception when double quotes are used see issue #19 WIP: Add fallback exception when double quotes are used - see issue #19 Jul 19, 2023
@mrchrisadams mrchrisadams changed the title WIP: Add fallback exception when double quotes are used - see issue #19 Add fallback exception when double quotes are used - see issue #19 Jul 19, 2023
@mrchrisadams
Copy link
Contributor Author

Oops, this has the gitpod.yml file added in. This makes it easy to spin up an environment if you're not already using github spaces, but it might be better as a separate PR. I'll see what the feedback is.

@cldellow cldellow merged commit 48d5c40 into cldellow:main Jul 22, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants