Fixes error in parameters of prepared statements during rewrite #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes cldellow#23 The dependencies for this package are unpinned. `sqlglot` upstream changed their rewriting to do more, so this package now needs to do a little less. This commit removes some rewriting that was failing with recent package versions, and pins `sqlglot` to `>=21.2` in `setup.py`.
|
For more context, since I helped Lars on this: This means that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23
The dependencies for this package are unpinned.
sqlglotupstream changed their rewriting to do more, so this package now needs to do a little less.This commit removes some rewriting that was failing with recent package versions, and pins
sqlglot >= 21.2insetup.py.In doing so, it gets table display working again in Datasette.