-
Notifications
You must be signed in to change notification settings - Fork 279
🚨 shellcheck'ed #68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
🚨 shellcheck'ed #68
Conversation
@cleanbrowsing , have you seen my PR and can you please review and merge it? Thanks… |
@cleanbrowsing , I rebased this PR and
|
The issue with this syntax is that it breaks on openbsd's default shell (the standard sh shell - openbsd user here). For example, this is what I get when I run with the changes:
That's why I kept the "x$1" syntax and the "if [ $?" format to test for the command results. Not sure what can be done to make it compatible with the standard sh shells and remove this format. |
Quick way to test:
file:
|
If I change to:
It works:
Using OpenBSD 6.9 |
I added a commit to fix your problem with openbsd's default shell. But I wonder, if shebang says "use bash" why openbsd is ignoring this and uses default shell (that is not bash?) 🤔 … |
Thanks! Checking that now. |
Ping @cleanbrowsing … |
1 similar comment
Ping @cleanbrowsing … |
Before:
After no complains anymore 👍🏻