fix dataframe index when downloading cleanlab columns #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axl1313
requested review from
sanjanag and
ryansingman
and removed request for
sanjanag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue that could occur when merging cleanlab columns with the original dataset. After sorting cleanlab columns by id column, it was possible for the index of the dataframe to no longer be in sorted order. Adding the
ignore_indexparameter when sorting the dataframe ensures that the resulting dataframe's index column is of the form 0, 1, ... n-1 so that we can merge with the original dataset usingdf.merge(cleanlab_columns, left_index=True, right_index=True)properly.How to test