Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve TLM documentation #216

Merged
merged 13 commits into from
Apr 16, 2024
Merged

Improve TLM documentation #216

merged 13 commits into from
Apr 16, 2024

Conversation

huiwengoh
Copy link
Contributor

  • hide the TLM init method from the docs page (it was confusing)
  • more details about the various quality presets

@jwmueller jwmueller self-requested a review April 13, 2024 00:54
jwmueller
jwmueller previously requested changes Apr 13, 2024
View reviewed changes
Copy link
Member

@jwmueller jwmueller left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pushed many changes, please review the new documentation closely.

Also had some remaining concerns I've left as comments for you. Please address them and then you can merge once ulyana does a final review after you address the comments. (no need for me to review again)

jwmueller and others added 2 commits April 15, 2024 21:02
@jwmueller @ulya-tkch
shorten
a942118 
Co-authored-by: Ulyana <[email protected]>
@jwmueller @ulya-tkch
better language
9768562 
Co-authored-by: Ulyana <[email protected]>
@huiwengoh @jwmueller
fix typos
75e2b8f 
Co-authored-by: Jonas Mueller <[email protected]>
@ulya-tkch ulya-tkch self-requested a review April 16, 2024 19:37
ulya-tkch
ulya-tkch approved these changes Apr 16, 2024
View reviewed changes
Copy link
Collaborator

@ulya-tkch ulya-tkch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docstring text lgtm

@huiwengoh huiwengoh dismissed jwmueller’s stale review April 16, 2024 20:06

mentioned above that re-review is not required

@huiwengoh huiwengoh merged commit 0a42e31 into main Apr 16, 2024
23 checks passed
@huiwengoh huiwengoh deleted the tlm-presets-docs branch June 17, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ulya-tkch ulya-tkch ulya-tkch approved these changes

@jwmueller jwmueller Awaiting requested review from jwmueller

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@huiwengoh @jwmueller @ulya-tkch