Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated download_array to properly read from literal string using StringIO wrapper #218

Merged
merged 2 commits into from
Apr 22, 2024

Conversation

mturk24
Copy link
Contributor

@mturk24 mturk24 commented Apr 19, 2024

This line below is causing deprecation warnings to appear wherever this line is used, namely in the cleanlab studio multiannotator tutorial.

pd_data: pd.DataFrame = pd.read_json(res_json[name], orient='records')

The following line in the multiannotator tutorial is what is returning the deprecation warning:

pred_probs = studio.download_pred_probs(cleanset_id)

The warning can be seen below:
Screenshot 2024-04-19 at 11 37 09 AM

@mturk24 mturk24 requested review from jwmueller and clu0 April 19, 2024 15:40
@jwmueller jwmueller requested review from axl1313 and removed request for jwmueller and clu0 April 19, 2024 21:29
@jwmueller
Copy link
Member

this seems like a high-stakes change, so please review it carefully @axl1313 . Thanks!

Copy link
Collaborator

@axl1313 axl1313 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@mturk24 mturk24 merged commit 31838ad into main Apr 22, 2024
23 checks passed
@mturk24 mturk24 deleted the update-deprecated-pandas-read-json-functionality branch April 22, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants