Patch: deberta success rate throttle #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huiwengoh
reviewed
May 30, 2024
huiwengoh
reviewed
May 30, 2024
| @@ -651,6 +652,9 @@ async def tlm_prompt( | |||
| await handle_tlm_client_error_from_resp(res, batch_index) | |||
| await handle_tlm_api_error_from_resp(res, batch_index) | |||
|
|
|||
| if not res_json.get("nli_deberta_success", True): | |||
| raise TlmPartialSuccess("Partial failure on deberta call -- slowdown request rate.") | |||
There was a problem hiding this comment.
Wouldn't this raise result in the return not actually returning the results to the user / trigger retries? Not entirely certain of the logic behind how the errors are handled here.
There was a problem hiding this comment.
no, not currently -- the context manager in the rate handler will swallow this type of exception, making it so that execution continues (returning the result to users)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See thread in backend PR