Anemoi hash r1cs parametrization #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtebbs
suggested changes
Nov 1, 2022
libsnark/gadgetlib1/gadgets/hashes/anemoi/anemoi_components.hpp
Outdated
Show resolved
Hide resolved
libsnark/gadgetlib1/gadgets/hashes/anemoi/anemoi_components.hpp
Outdated
Show resolved
Hide resolved
libsnark/gadgetlib1/gadgets/hashes/anemoi/anemoi_components.tcc
Outdated
Show resolved
Hide resolved
libsnark/gadgetlib1/gadgets/hashes/anemoi/anemoi_parameters.hpp
Outdated
Show resolved
Hide resolved
| "14981678621464625851270783002338847382197300714436467949315" | ||
| "331057125308909861"); | ||
|
|
||
| const libff::bigint<libff::Fr<libff::bls12_381_pp>::num_limbs> |
There was a problem hiding this comment.
To confirm, for the other curves the script computes the values, but we don't have a a specialization of anemoi_parameters yet? (That's fine, we just need to track this.)
There was a problem hiding this comment.
Yes, that is correct. Should I create an issue?
libsnark/gadgetlib1/gadgets/hashes/anemoi/tests/test_anemoi_gadget.cpp
Outdated
Show resolved
Hide resolved
libsnark/gadgetlib1/gadgets/hashes/anemoi/anemoi_parameters.hpp
Outdated
Show resolved
Hide resolved
libsnark/gadgetlib1/gadgets/hashes/anemoi/tests/test_anemoi_gadget.cpp
Outdated
Show resolved
Hide resolved
dtebbs
reviewed
Nov 1, 2022
vesselinux
force-pushed
the
anemoi-hash-r1cs-parametrization
branch
2 times, most recently
from
2d475ad to
e33c10b
Compare
added 5 commits
November 2, 2022 15:19
…oi-hash repo (matrix transpose bug fix, instances for several new curves)
…ts instantiation for the curve bls12-381
…en curve in a separate hpp file. removed all debug macros. added a separate class with anemoi parameters used for debug that is passed instead of the curve parameters class in debug mode. removed the interface of the anemoi round gadget as it is being developed in a dedicated branch.
vesselinux
force-pushed
the
anemoi-hash-r1cs-parametrization
branch
from
e33c10b to
2c25f01
Compare
added 6 commits
November 4, 2022 14:06
…lt variables have names that are self-explanatory (#76 (comment))
…nnecessary ppT type (#76 (comment)).
…ers class to a .tcc file (#76 (comment))
…e small values from const BignumT to constexpr size_t (#76 (comment))
dtebbs
reviewed
Nov 7, 2022
dtebbs
suggested changes
Nov 7, 2022
libsnark/gadgetlib1/gadgets/hashes/anemoi/anemoi_parameters.tcc
Outdated
Show resolved
Hide resolved
added 6 commits
November 8, 2022 13:18
…from bignum to size_t to match the anemoi_parameters class
…e that alpha is equal to 5
…rom the libsnark repo; added a readme file explaining how to download this implementation from the Anemoi repo
dtebbs
added a commit
that referenced
this pull request
Nov 10, 2022
…dgets Anemoi hash r1cs remove duplicate gadgets (depends on #76)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.