-
Notifications
You must be signed in to change notification settings - Fork 26
Chart dependencies #15
Chart dependencies #15
Conversation
also fixed a typo in ci checks |
Hey @valeriano-manassero, |
I just tested latest stable on my testing cluster and they where working. I don't think there is any problem do downgrade to already used version. Will test the chart and update PR asap! |
Hey @sapir-allegro , I updated dependencies versions to get in sync with the ones previously used. Since I'm now using my fork to deploy ClearML I tested this PR very quickly and looks good to me but I suggest to install on one of your cluster to do some intensive tests. Jfi even newest versions of mongo,redis and elastic works from what I can see. Let me know if it's ok now. |
Hey @valeriano-manassero, Regarding the newer versions - I'm happy to hear that it works! But we still need to test those before making such a change and it would probably take some time. I prefer using the current versions so we can merge this PR asap :) |
Hey @sapir-allegro , I put back env vars as requested. Just too be extremely sure, since this is a big PR, I suggest to test a complete installation on your environments. As I said before, I tried this chart on my env and lgtm but better play safe 😄 |
Great thanks! |
@valeriano-manassero can we close this PR now that it was actually adopted as the |
Absolutely, just did it 👍 |
Original PR on Trains chart was referred here:
#12