This repository has been archived by the owner on Jan 24, 2023. It is now read-only.
Make agent groups a map #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manojlds
force-pushed
the
agent-groups-map
branch
from
b8ed616 to
ef0580c
Compare
|
@manojlds a quick question - won't we be a little limited when naming an agent group when the name is a map key? wouldn't it make sense to still keep a name property in the map? |
manojlds
force-pushed
the
agent-groups-map
branch
from
ef0580c to
64f7a92
Compare
|
@jkhenning - have updated to make it use the name within the config rather than the key. |
|
Thanks @manojlds! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change agentgroups from a list to a map to allow easy override from external values file.