This repository has been archived by the owner on Jan 24, 2023. It is now read-only.
Agent docker mode enable/disable #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @valeriano-manassero ! |
In values.yaml there is now |
|
@valeriano-manassero , nice! |
|
@bmartinn do I have to bump up Chart version too? |
No need, we'll take care of that in the Helm repository once we release a version. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this it's possible to disable dockerMode for an Agent deployment in k8s. I found this especially useful when I don't want to get over K8s itself creating directly containers in Docker daemon.
Moreover, in this way it's possible to directly use the GPU attached to agent pod by a gpu-operator.
I didn't update version in Chart.yaml because I'm not sure if I need to raise a specific PR for that. If needed I can add it here.