Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the lms1xx library with EasyMile's (https://github.com/EasyMile/lms1xx), the API is very similar, and includes the following improvements:
I've added it as an external CMake project, but I don't know if it'd be better as a separate Bloom package released into ROS and have the LMS1xx ROS driver depend on it or just copying the source files into this repository.
One semi-drawback of using this library is that it depends on C++11. Kinetic added C++11 as a requirement for compilers, but Indigo is still at C++03. I'm not sure what the most viable path is, but I guess it'd mean creating a new branch for Kinetic and onwards.