Play sim automatically #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hilary-luo
requested review from
tonybaltovski,
mhosmar-cpr,
civerachb-cpr,
roni-kreinin and
luis-camero
and removed request for
a team
|
@hilary-luo Can you keep this the default behaviour but add a launch argument allowing the sim to be launched paused? |
|
@roni-kreinin I can do that, is there an expected use case for this? As things currently stand, if they do not press play within 5 seconds of launch then the simulation will fail. |
|
Its just to maintain backwards compatibility with how it worked before. |
…ior although default is true
roni-kreinin
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #46, #50
This change is in reaction to the following PR: ros-controls/ros2_control#1659 where a timeout is added for the switch controller service. This timeout is hardcoded as 5 seconds here: https://github.com/ros-controls/ros2_control/blob/8779757f7e5cdb5e6998d9b162e65015003e3c1f/controller_manager/controller_manager/spawner.py#L332
Further discussion should be had on proposing to parameterize that timeout so that we can adapt for low resource sims which are slow to launch and/or making the timeout based on ROS time.