Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize packaging #172

Merged
merged 11 commits into from
Oct 24, 2023
Merged

Modernize packaging #172

merged 11 commits into from
Oct 24, 2023

Conversation

cleder
Copy link
Owner

@cleder cleder commented Oct 23, 2023

workerB

Drop setup.py in favour of pyproject.toml

@cleder cleder linked an issue Oct 23, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5476bc8) 100.00% compared to head (c60c834) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##           develop      #172   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           20        21    +1     
  Lines         2225      2244   +19     
=========================================
+ Hits          2225      2244   +19     
Files Coverage Δ
pygeoif/__init__.py 100.00% <100.00%> (ø)
pygeoif/about.py 100.00% <100.00%> (ø)
pygeoif/exceptions.py 100.00% <ø> (ø)
pygeoif/factories.py 100.00% <100.00%> (ø)
pygeoif/feature.py 100.00% <100.00%> (ø)
pygeoif/functions.py 100.00% <100.00%> (ø)
pygeoif/geometry.py 100.00% <100.00%> (ø)
pygeoif/types.py 100.00% <100.00%> (ø)
tests/test_factories.py 100.00% <100.00%> (ø)
tests/test_geometrycollection.py 100.00% <ø> (ø)
... and 2 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@watermelon-copilot-for-code-review
Copy link

watermelon-copilot-for-code-review bot commented Oct 23, 2023

WatermelonAI Summary

This pull request is focused on modernizing the packaging of the project. The commits show the following changes made:

  • Testing with Python 3.13
  • Replacing setup.py with pyproject.toml for package configuration
  • Formatting the pyproject.toml file
  • Making the version dynamic for easier maintenance
  • Removing manifest.in file
  • Configuring Ruff strictness (presumably for code formatting)
  • Applying automatic fixes from pre-commit.com hooks
  • Fixing style issues with Black and isort
  • Merging the "develop" branch into the new packaging changes branch
  • Fixing Ruff errors
  • Using a protocol instead of "Any" for improved typing

Overall, these commits demonstrate efforts to update and improve the packaging process of the project, enhancing its maintainability and adherence to coding standards.

GitHub PRs

Click here to login to Jira
Click here to login to Confluence
Click here to login to Slack
Click here to login to Notion
Click here to login to Linear
Click here to login to Asana
pygeoif is an open repo and Watermelon will serve it for free.
🍉🫶

@what-the-diff
Copy link

what-the-diff bot commented Oct 23, 2023

PR Summary

  • Expansion of Python Version Testing
    Status checks and tests have been expanded to include Python version 3.13 for broader compatibility.
  • Excluded Cache and Configuration Files
    Updates to .gitignore exclude a number of miscellaneous configuration caches and virtual environment directories to keep the repository clean.
  • Updated Pre-Commit Checks
    Several pre-commit checks have been updated to latest versions such as 'black', 'ruff', 'mypy', and 'pyroma' for improved source code analysis and formatting.
  • New Pre-Commit Hooks Installed
    New pre-commit hooks validate-pyproject and pyprojectsort were added for additional validation and sorting, respectively.
  • Enhanced Project Documentation
    The README.rst file was updated to improve the wording and to include an explanation about support for alternative Python implementations.
  • New Project Release
    A new release version 1.1.1 was added to our project history, indicating improvements and additional features.
  • Project Configuration Updates
    The project configuration pyproject.toml has been enhanced and now replaces the setup.py file, making project setup more modern and straightforward. This includes the addition of various project metadata for better understanding of the project.
  • Removal of Redundant Files
    The setup.py file was removed to minimize redundancy, considering updated project setup procedures.

@ghost
Copy link

ghost commented Oct 23, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@cleder cleder merged commit 806c46e into develop Oct 24, 2023
38 of 40 checks passed
@cleder cleder deleted the 170-modernize-packaging branch October 24, 2023 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modernize packaging
1 participant