Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix <GoogleOneTap /> examples #1950

Merged
merged 4 commits into from
Jan 29, 2025
Merged

Fix <GoogleOneTap /> examples #1950

merged 4 commits into from
Jan 29, 2025

Conversation

wobsoriano
Copy link
Member

@wobsoriano wobsoriano commented Jan 27, 2025

🔎 Previews:

What does this solve?

  • The <GoogleOneTap /> component examples are placed incorrectly. The <GoogleOneTap /> renders a <div> element and it can't be a direct child of <html>

What changed?

  • Moved component placements inside <body>

Checklist

  • I have clicked on "Files changed" and performed a thorough self-review
  • I have added the "deploy-preview" label and added the preview link(s) to this PR description
  • All existing checks pass

Copy link

Hey, here’s your docs preview: https://clerk.com/docs/pr/1950

@wobsoriano wobsoriano marked this pull request as ready for review January 27, 2025 20:43
@wobsoriano wobsoriano requested a review from a team as a code owner January 27, 2025 20:43
Copy link
Member

@alexisintech alexisintech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch 😸💖 I've updated the examples to be more simple, and added examples for React and Remix! I tested all of these examples and they work :)
if there's no issues here, feel free to merge

@wobsoriano wobsoriano merged commit 915d8ae into main Jan 29, 2025
6 checks passed
@wobsoriano wobsoriano deleted the rob/google-one-tap-fix branch January 29, 2025 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants