feat: Add support for BAPI custom permissions endpoints #183
Conversation
| @@ -24,3 +25,62 @@ func (s *InstanceService) ListOrganizationPermissions(params ListInstanceOrganiz | |||
| } | |||
| return response, nil | |||
| } | |||
|
|
|||
| type CreateInstanceOrganizationPermissionParams struct { | |||
There was a problem hiding this comment.
🙃 Can't we name this CreateOrganizationPermissionsParams?
There was a problem hiding this comment.
What if we introduce the same method on the organization resource/service as well? As those are under the same package, there will be a name conflict
There was a problem hiding this comment.
What if we introduce the same method on the organization resource/service as well? As those are under the same package, there will be a name conflict
Yes let's keep it with instance in the name, at least for this iteration of the project.
| return &orgPermission, nil | ||
| } | ||
|
|
||
| type UpdateInstanceOrganizationPermissionParams struct { |
There was a problem hiding this comment.
🙃 Same about the name, UpdateOrganizationPermissionParams.
And since it's the same parameters with Create, would it make sense to have only one type, OrganizationPermissionParams?
There was a problem hiding this comment.
It is the same fields, except they are optional in the update params. Is there a better way to handle this given that?
Will merge this PR for now, but happy to open a new one to clean it up!
| @@ -24,3 +25,62 @@ func (s *InstanceService) ListOrganizationPermissions(params ListInstanceOrganiz | |||
| } | |||
| return response, nil | |||
| } | |||
|
|
|||
| type CreateInstanceOrganizationPermissionParams struct { | |||
There was a problem hiding this comment.
What if we introduce the same method on the organization resource/service as well? As those are under the same package, there will be a name conflict
Type of change
Description
Add read, create, update, delete endpoints for custom permission
Related Issue (optional)