feat: Add session claims helper methods to check roles and permissions #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agis
approved these changes
Jan 11, 2024
chanioxaris
approved these changes
Jan 11, 2024
georgepsarakis
approved these changes
Jan 11, 2024
| // user has permission | ||
| hasPermission := dummySessionClaims.HasPermission("org:billing:manage") | ||
| assert.True(t, hasPermission) | ||
|
|
There was a problem hiding this comment.
🔧 You could also assert that the helper finds both permissions defined in the claims:
clerk-sdk-go/clerk/tokens_test.go
Line 56 in fede4e5
This case may provide an additional guarantee that we perform an exhaustive search.
There was a problem hiding this comment.
Will add! Thanks for the suggestion
mzhong9723
force-pushed
the
mz/core-1351
branch
from
7c37e14 to
c587197
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
HasPermission()andHasRole()to session claims