chore(clerk-js,chrome-extension): Check for RHC (#5040)

.changeset/cyan-kids-boil.md

@@ -0,0 +1,2 @@
+---
+---

packages/chrome-extension/package.json

@@ -33,7 +33,7 @@
   ],
   "scripts": {
     "build": "tsup",
-    "postbuild": "node ../../scripts/search-for-rhc.mjs dist",
+    "postbuild": "node ../../scripts/search-for-rhc.mjs directory dist",
     "build:declarations": "tsc -p tsconfig.declarations.json",
     "clean": "rimraf ./dist",
     "dev": "tsup --watch",

packages/clerk-js/package.json

@@ -32,6 +32,7 @@
   ],
   "scripts": {
     "build": "pnpm build:bundle && pnpm build:declarations",
+    "postbuild": "node ../../scripts/search-for-rhc.mjs file dist/clerk.no-rhc.mjs",
     "build:analyze": "rspack build --config rspack.config.js --env production --env variant=\"clerk.browser\" --env analysis --analyze",
     "build:bundle": "pnpm clean && rspack build --config rspack.config.js --env production",
     "build:declarations": "tsc -p tsconfig.declarations.json",

scripts/search-for-rhc.mjs

@@ -7,13 +7,32 @@
 
 import { $, argv } from 'zx';
 
-const buildFolder = argv._[0];
-console.log(`🔍 Inspecting folder: ${buildFolder}`);
-const flags = ['--recursive', '--quiet', '--include=*.js', '--include=*.mjs'];
-
-// Leveraging https://google.github.io/zx/process-promise#nothrow to avoid throwing an error if the command fails
-if ((await $`grep ${flags} 'https://\${scriptHost}/npm/@clerk/clerk-js' ${buildFolder}`.exitCode) === 0) {
-  throw new Error('Found RHC in build output');
-} else {
-  console.log('✅ No RHC found in build output');
+const targetType = argv._[0]; // file | directory
+const target = argv._[1]; // Target of the resource
+
+async function asyncSearchRHC(name, search) {
+  const cmd = () =>
+    targetType === 'directory'
+      ? $`grep -rFq --include=\\*.js --include=\\*.mjs "${search}" ${target}`
+      : $`grep -Fq "${search}" ${target}`;
+
+  if ((await cmd().exitCode) === 0) {
+    throw new Error(`Found ${name} related RHC in build output. (Search: \`${search}\`)`);
+  }
+
+  return;
 }
+
+await Promise.allSettled([
+  asyncSearchRHC('Turnstile', 'cloudflare.com/turnstile/v0/api.js'),
+  asyncSearchRHC('clerk-js Hotloading', '/npm/@clerk/clerk-js'),
+  asyncSearchRHC('Google One Tap', 'accounts.google.com/gsi/client'),
+]).then(results => {
+  const errors = results.filter(result => result.status === 'rejected').map(result => result.reason.message);
+
+  if (errors.length > 0) {
+    throw new Error(`\n${errors.join('\n')}`);
+  }
+
+  console.log('✅ No RHC found in build output');
+});