fix(clerk-js): Ensure only one action is present in UserProfile sections #5030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
9 tasks
🦋 Changeset detectedLatest commit: 17a2424 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jacekradko
reviewed
Jan 29, 2025
| @@ -114,6 +116,7 @@ const PhoneMenu = ({ phone }: { phone: PhoneNumberResource }) => { | |||
| const card = useCardState(); | |||
| const { open } = useActionContext(); | |||
| const { user } = useUser(); | |||
| const phoneId = phone.id; | |||
There was a problem hiding this comment.
Just curious what the thought behind this assignment is
There was a problem hiding this comment.
A consistent identifier used below to ensure the actions below are scoped to the appropriate phone number.
octoper
approved these changes
Feb 5, 2025
anagstef
approved these changes
Feb 5, 2025
LekoArts
approved these changes
Feb 5, 2025
LekoArts
deleted the
alexcarpenter/sdki-817-verify-email-code-ui-remains-in-place-even-if-the-email-is-2
branch
wobsoriano
pushed a commit
that referenced
this pull request
Feb 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
BEFORE
Screen.Recording.2025-01-28.at.1.20.40.PM.mov
AFTER
Screen.Recording.2025-01-28.at.1.19.27.PM.mov
Fixes SDKI-817
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change