Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(clerk-js): Adjust verification modal placement and card logo #5153

Merged
merged 3 commits into from
Feb 14, 2025
Merged

fix(clerk-js): Adjust verification modal placement and card logo #5153

merged 3 commits into from
Feb 14, 2025

Conversation

alexcarpenter
Copy link
Member

@alexcarpenter alexcarpenter commented Feb 13, 2025 •
edited
Loading

Description

  • Vertically centers verification modal
  • Removes logo usage within verification modal
BEFORE AFTER
Screenshot 2025-02-13 at 3 55 41 PM Screenshot 2025-02-13 at 3 56 35 PM

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 13, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 3f5e2f5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@clerk/clerk-js Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Feb 13, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clerk-js-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 13, 2025 9:01pm

@alexcarpenter alexcarpenter marked this pull request as ready for review February 13, 2025 20:59
@alexcarpenter alexcarpenter requested review from panteliselef and octoper and removed request for panteliselef February 13, 2025 21:00
panteliselef
panteliselef approved these changes Feb 14, 2025
View reviewed changes
Copy link
Member

@panteliselef panteliselef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This goes against the original designs, but I find the change reasonable.

@alexcarpenter alexcarpenter merged commit 14fd729 into main Feb 14, 2025
29 checks passed
@alexcarpenter alexcarpenter deleted the alexcarpenter/verification-modal-tweaks branch February 14, 2025 15:24
@clerk-cookie clerk-cookie mentioned this pull request Feb 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@octoper octoper octoper approved these changes

@anagstef anagstef anagstef approved these changes

@panteliselef panteliselef panteliselef approved these changes

Assignees
No one assigned
Labels
clerk-js
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alexcarpenter @octoper @anagstef @panteliselef @clerk-cookie