Skip to content

Commit

Permalink
Merge branch 'master' into slides-a11y
Browse files Browse the repository at this point in the history
* master:
  Update CHANGELOG.md
  updated changelog
  Correct usage of HTML heading levels & other fixes (#124)
  • Loading branch information
clhenrick committed Nov 22, 2023
2 parents 7b659cd + abdd201 commit 4507ac8
Show file tree
Hide file tree
Showing 35 changed files with 470 additions and 692 deletions.
11 changes: 11 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,17 @@
# Am I Rent Stabilized Changelog
This changelog describes significant changes to the project. It was first created on November 29, 2020 so does not account for the entire project's history.

## 2023-11-22 A11Y improvements & bug fixes ([#124](https://github.com/clhenrick/am-i-rent-stabilized/pull/124))

Accessibility fixes:
- Corrected the usage of heading levels (h1-h6) through out the website so that there is one h1 per page and are sequential (see issue #85)
- Fixes the main navigation's hamburger button (previously was a clickable `<div>`) by making it an actual button.

Other bug fixes & improvements:
- fixes the "start over" button click handler which was previously not working
- cleaned up the main navigation CSS
- removed some unused SCSS partials

## 2023-02-03 App Dependency updates ([#120](https://github.com/clhenrick/am-i-rent-stabilized/pull/120))
- Removed `node-sass` in favor of (Dart) `sass`
- Upgraded `webpack` to latest 4.x version 4.46.0
Expand Down
8 changes: 4 additions & 4 deletions app/public/locales/how-en.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,13 @@
"resources": "Resources"
},
"nav_side": {
"h3": "Jump to a topic:",
"h2": "Jump to a topic:",
"how": "How it Works",
"code": "Code &amp; Data",
"credits": "Credits"
},
"how": {
"h1": "How This Site Works",
"h2": "How This Site Works",
"p01": [
"This site checks your building's address and sees if it matches a list of properties that are ",
"likely to have rent stabilized apartments. ",
Expand Down Expand Up @@ -46,7 +46,7 @@
"p07": "The database used by this site combines the properties on the DHCR list with those that are likely to have rent stabilized units and are not currently on the DHCR list in order to get an estimate of the locations of all rent stabilized apartments in NYC."
},
"code": {
"h1": "Code and Data",
"h2": "Code and Data",
"p": "You may inspect and download the code for this site, download the data it uses, and download Excel and CSV files of the DHCR rent stabilized building list from the links below.",
"ul": [
"Github Repo (code)",
Expand All @@ -55,7 +55,7 @@
]
},
"credits": {
"h1": "Credits",
"h2": "Credits",
"h3": "And most of all thanks to you for visiting this site and checking your rent history!",
"p01": "The following people and organizations helped tremendously to make this project happen.",
"ul": [
Expand Down
8 changes: 4 additions & 4 deletions app/public/locales/how-es.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,13 @@
"resources": "Recursos"
},
"nav_side": {
"h3": "Ir a un tema:",
"h2": "Ir a un tema:",
"how": "¿Cómo funciona?",
"code": "Código y Datos",
"credits": "Créditos"
},
"how": {
"h1": "Cómo funciona esta página web",
"h2": "Cómo funciona esta página web",
"p01": [
"Esta página web verifica una dirección residencial e indica si coincide con la lista de propiedades que ",
"probablemente tienen apartamentos con renta estabilizada. ",
Expand Down Expand Up @@ -46,7 +46,7 @@
"p07": "La base de datos que utiliza esta página web combina las propiedades en la lista del DHCR con aquellas que tienen altas probabilidades de tener unidades con renta estabilizada que no están en la lista con el propósito de tener un estimado de la ubicación de todos los apartamentos con renta estabilizada en la ciudad de Nueva York."
},
"code": {
"h1": "Código y Datos",
"h2": "Código y Datos",
"p": "Usted puede revisar y descargar el código de ésta página web. Puede descargar un archivo de Excel y los archivos CSV del DHCR con la lista de los edificios con renta estabilizada. Enlaces a continuación.",
"ul": [
"Github Repo (código)",
Expand All @@ -55,7 +55,7 @@
]
},
"credits": {
"h1": "Créditos",
"h2": "Créditos",
"h3": "Gracias a los usuarios por visitar nuestra página web y verificar su historial de renta.",
"p01": "Las siguientes personas y organizaciones hicieron este proyecto posible.",
"ul": [
Expand Down
8 changes: 4 additions & 4 deletions app/public/locales/how-zh.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,13 @@
"resources": "相关资料"
},
"nav_side": {
"h3": "跳到相关话题",
"h2": "跳到相关话题",
"how": "本站如何运作",
"code": "程序 &amp; 数据",
"credits": "感谢"
},
"how": {
"h1": "本站如何运作",
"h2": "本站如何运作",
"p01": [
"在你输入你的地址之后,本站将其与数据库中极有可能租金稳定的公寓比较。",
"",
Expand Down Expand Up @@ -43,12 +43,12 @@
"p07": "本站的数据库包含DHR的租金稳定地址的清单以及我们认为极有可能租金稳定的,但是没有登记在案的楼房。我们用这个数据库来估计你纽约城所有的地址是否可能租金稳定。"
},
"code": {
"h1": "程序 &amp; 数据",
"h2": "程序 &amp; 数据",
"p": "你可以通过以下链接来观察及下载本站的程序和数据,以及下载HCR的清单。",
"ul": ["程序", "数据", "DHCR租金稳定的清单"]
},
"credits": {
"h1": "感谢",
"h2": "感谢",
"h3": "但是最要感谢的还是你的参与!",
"p01": "以下是对本站作出贡献的个人以及组织。",
"ul": [
Expand Down
16 changes: 8 additions & 8 deletions app/public/locales/main-en.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,12 @@
"mobile_msg": "Please rotate your device or make your browser window taller.",
"slide01": {
"h1": "Half of All Apartments in NYC Are Rent Stabilized.",
"h2": "Find out if yours is one of them.",
"subhead": "Find out if yours is one of them.",
"landing": "Or jump ahead to",
"go_step_4": "When you receive your rent history"
},
"slide02": {
"h1": "First, let's have your building address and borough.",
"h2": "First, let's have your building address and borough.",
"privacy": "We won't share this information or use it commericially.",
"form": {
"label": "Street Address",
Expand All @@ -36,7 +36,7 @@
},
"slide04": {
"yes": {
"h1": "Your apartment <em>might be</em> rent stabilized!",
"h2": "Your apartment <em>might be</em> rent stabilized!",
"p": "But there's only one way to know for sure, so keep reading."
},
"no": {
Expand All @@ -48,7 +48,7 @@
}
},
"slide05": {
"h1": "Request your rent history from the NY Department of Homes and Community Renewal.",
"h2": "Request your rent history from the NY Department of Homes and Community Renewal.",
"mail": "Request it by email",
"phone": "Call them at ",
"visit": "You can also visit a",
Expand All @@ -57,16 +57,16 @@
"mailed": "It will be mailed to your apartment."
},
"slide06": {
"h1": "After requesting your rent history, add a reminder to your calendar.",
"h2": "After requesting your rent history, add a reminder to your calendar.",
"arrive": "It shouldn't take more than a week to arrive in the mail",
"friends": "Meanwhile, have your friends and neighbors check their apartments too!"
},
"slide07": {
"h1": "Once you receive it, look at what previous tenants paid and if their rent was stabilized.",
"h2": "Once you receive it, look at what previous tenants paid and if their rent was stabilized.",
"p": "View a sample rent history."
},
"slide08": {
"h1": "If they were paying a lot less than you are, here's how to take action:",
"h2": "If they were paying a lot less than you are, here's how to take action:",
"option01": "Option 1:",
"no_local_tr": {
"a": "Contact a tenants rights group for advice.",
Expand All @@ -82,7 +82,7 @@
"p2": "But be aware that your landlord will be notified when you file a complaint."
},
"slide09": {
"h1": "Nice Work!",
"h2": "Nice Work!",
"start": "Start Over",
"learn": "Learn More",
"share": "Share it!"
Expand Down
16 changes: 8 additions & 8 deletions app/public/locales/main-es.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,12 @@
"mobile_msg": "Favor de rotar su celular.",
"slide01": {
"h1": "La Mitad de Todos Los Apartamentos en la Ciudad de Nueva York Tienen Renta Estabilizada.",
"h2": "Descubra si el suyo es uno de ellos.",
"subhead": "Descubra si el suyo es uno de ellos.",
"landing": "O salte este paso hasta",
"go_step_4": "Una vez recibido el historial de renta"
},
"slide02": {
"h1": "Primero, escriba la dirección del edificio y el distrito donde se encuentra.",
"h2": "Primero, escriba la dirección del edificio y el distrito donde se encuentra.",
"privacy": "No compartiremos su información, tampoco será usada con propósitos comerciales.",
"form": {
"label": "Dirección",
Expand All @@ -36,7 +36,7 @@
},
"slide04": {
"yes": {
"h1": "¡El apartamento <em>podría</em> tener renta estabilizada!",
"h2": "¡El apartamento <em>podría</em> tener renta estabilizada!",
"p": "Pero, hay solo una manera de asegurarse, siga leyendo."
},
"no": {
Expand All @@ -48,7 +48,7 @@
}
},
"slide05": {
"h1": "Para solicitar el historial de renta de su apartamento al Departamento de Viviendas y Renovación de Comunidades de Nueva York.",
"h2": "Para solicitar el historial de renta de su apartamento al Departamento de Viviendas y Renovación de Comunidades de Nueva York.",
"mail": "Puede solicitarse vía email.",
"phone": "Llamando a las oficinas al ",
"visit": "También se puede visitar",
Expand All @@ -57,16 +57,16 @@
"mailed": "El historial llegará por correo."
},
"slide06": {
"h1": "Después de solicitar el historial de renta añada un recordatorio a su calendario.",
"h2": "Después de solicitar el historial de renta añada un recordatorio a su calendario.",
"arrive": "Crear un recordatorio en su calendario.",
"friends": "El historial debe llegar en menos de una semana. Mientras tanto, haga que sus amigos y vecinos soliciten uno también."
},
"slide07": {
"h1": "Una vez recibido el historial, se puede leer lo que inquilinos anteriores pagaban y si la renta se encontraba estabilizada anteriormente.",
"h2": "Una vez recibido el historial, se puede leer lo que inquilinos anteriores pagaban y si la renta se encontraba estabilizada anteriormente.",
"p": "Ver un ejemplo de historial de renta."
},
"slide08": {
"h1": "Si los inquilinos anteriores pagaban mucho menos de lo que se paga ahora, seguir estos pasos:",
"h2": "Si los inquilinos anteriores pagaban mucho menos de lo que se paga ahora, seguir estos pasos:",
"option01": "Opción 1:",
"no_local_tr": {
"a": "Contactar un grupo de derechos para inquilinos para recibir consejo.",
Expand All @@ -82,7 +82,7 @@
"p2": "Importante: El propietario de su apartamento será notificado que usted tomó dicha acción. "
},
"slide09": {
"h1": "¡Buen Trabajo!",
"h2": "¡Buen Trabajo!",
"start": "Empezar de nuevo",
"learn": "Aprenda más",
"share": "¡Compartalo!"
Expand Down
16 changes: 8 additions & 8 deletions app/public/locales/main-zh.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,12 @@
"mobile_msg": "请旋转你的屏幕",
"slide01": {
"h1": "在纽约,至少有一半的住房租金是稳定的。",
"h2": "也许你的住房是其中之一。",
"subhead": "也许你的住房是其中之一。",
"landing": "如果你收到过你的房租历史档案,",
"go_step_4": "你可以跳到下一个话题。"
},
"slide02": {
"h1": "首先,输入你的地址和镇区。",
"h2": "首先,输入你的地址和镇区。",
"privacy": "你的信息不会被用于商业用途。",
"form": {
"label": "街道地址",
Expand All @@ -36,7 +36,7 @@
},
"slide04": {
"yes": {
"h1": "你的公寓极有可能是租金稳定的!",
"h2": "你的公寓极有可能是租金稳定的!",
"p": "- 但只有一个办法能够百分百地确定, 请继续阅读。"
},
"no": {
Expand All @@ -48,7 +48,7 @@
}
},
"slide05": {
"h1": "向纽约州DHCR要求你的租金历史",
"h2": "向纽约州DHCR要求你的租金历史",
"mail": "向DHCR写一封邮件",
"phone": "致电",
"visit": "走访",
Expand All @@ -57,16 +57,16 @@
"mailed": "这份租金历史会被邮寄到你的公寓。"
},
"slide06": {
"h1": "在你写信/致电/走访之后,在你的月历里设定一个提醒。",
"h2": "在你写信/致电/走访之后,在你的月历里设定一个提醒。",
"arrive": "通常来讲,回信不会超过一个星期。",
"friends": "与此同时,动员你的邻里以及亲朋好友去调查他们的公寓!"
},
"slide07": {
"h1": "在你收到你的租金历史之后,在纸上找到以下信息。 1: 以往的住客所付的租金。 2: 他们的租金是否稳定。",
"h2": "在你收到你的租金历史之后,在纸上找到以下信息。 1: 以往的住客所付的租金。 2: 他们的租金是否稳定。",
"p": "点击查看样板租金历史。"
},
"slide08": {
"h1": "如果以往的住客付的租金远远少于你现在所付的租金,请开始行动:",
"h2": "如果以往的住客付的租金远远少于你现在所付的租金,请开始行动:",
"option01": "方式一:",
"no_local_tr": {
"a": "向一个住客权利组织取得建议。",
Expand All @@ -82,7 +82,7 @@
"p2": "注意:你的投诉是非匿名的。在你投诉之后,你的房东会收到通知。"
},
"slide09": {
"h1": "做得好!",
"h2": "做得好!",
"start": "重新来过",
"learn": "了解更多",
"share": "分享给其他人!"
Expand Down
4 changes: 2 additions & 2 deletions app/public/locales/resources-en.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"resources": "Resources"
},
"nav_side": {
"h3": "Jump to an area:",
"h2": "Jump to an area:",
"nongov": "Tenants Rights Orgs",
"citywide": "Citywide",
"boro": "By Borough",
Expand Down Expand Up @@ -164,7 +164,7 @@
}
},
"gov": {
"h3": "Government Resources",
"h2": "Government Resources",
"p": "These are links to websites of departments operating within the state and city levels of government that relate to housing and property ownership in NYC.",
"ul": [
{
Expand Down
4 changes: 2 additions & 2 deletions app/public/locales/resources-es.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"resources": "Recursos"
},
"nav_side": {
"h3": "Ir a",
"h2": "Ir a",
"nongov": "Organizaciones de Derechos para Inquilinos",
"citywide": "En toda la Ciudad",
"boro": "Por Distrito",
Expand Down Expand Up @@ -164,7 +164,7 @@
}
},
"gov": {
"h3": "Recursos Gubernamentales",
"h2": "Recursos Gubernamentales",
"p": "Estos son enlaces a páginas web de departamentos que operan dentro del estado a nivel de ciudad que se relacionan con viviendas y propiedades en la ciudad de Nueva York.",
"ul": [
{
Expand Down
4 changes: 2 additions & 2 deletions app/public/locales/resources-zh.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"resources": "相关资料"
},
"nav_side": {
"h3": "跳到相关话题",
"h2": "跳到相关话题",
"nongov": "与住客权利相关的机构",
"citywide": "全市",
"boro": "镇区",
Expand Down Expand Up @@ -164,7 +164,7 @@
}
},
"gov": {
"h3": "政府资源",
"h2": "政府资源",
"p": "这些政府链接来次纽约州和城市层面运作部门的网站,涉及住房和财产所有权。",
"ul": [
{
Expand Down
Loading

0 comments on commit 4507ac8

Please sign in to comment.