Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unhandled exception during autocomplete fix #109

Merged
merged 4 commits into from
Nov 10, 2023
Merged

Unhandled exception during autocomplete fix #109

merged 4 commits into from
Nov 10, 2023

Conversation

opirko
Copy link
Contributor

@opirko opirko commented Nov 9, 2023

Fixes the issue mentioned in #108

Copy link
Collaborator

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems some builds are failing! can you check?

@opirko
Copy link
Contributor Author

opirko commented Nov 10, 2023

Okay, I think it's fixed. It was failing with Click 7 due to the missing () in Click decorators.

@opirko opirko requested a review from auvipy November 10, 2023 09:29
@auvipy
Copy link
Collaborator

auvipy commented Nov 10, 2023

its failing again. can you recheck? we might consider dropping click 7 very soon but before that....

@opirko
Copy link
Contributor Author

opirko commented Nov 10, 2023

Now it was due to flake saying I got one space before inline comment instead of two (only in python 3.7 test for some reason). Oh well, here's hoping third time is the charm :D

@auvipy auvipy merged commit 43c7c50 into click-contrib:master Nov 10, 2023
32 checks passed
@jathanism
Copy link

Nice to see this fixed. Any plans on releasing it anytime soon? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants