Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types: expose fallbackRouter in ManhattanRouterArguments #2346

Conversation

coyoteecd
Copy link
Contributor

Description

The manhattan router has an undocumented fallbackRouter option that defaults to "orthogonal". This PR exposes the option in ManhattanRouterArguments so it can be used by consumers and adds documentation for it.

In our app, we found it useful to provide a fallbackRouter that retries manhattan with more relaxed options before falling back to orthogonal. E.g. first manhattan tries with restricted start/end directions, while the second one uses all possible start/end directions.

@kumilingus
Copy link
Contributor

Thank you!

@kumilingus kumilingus merged commit b65f3aa into clientIO:master Sep 21, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants