Attempt at consolidating our docker image update pipelines #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, if you look at the genegraph repo, we've got a bunch of different cloudbuilds that all contain largely the same routine:
Each cloudbuild has its own (mostly copied) version of those steps in a long bash
&&chain. To avoid having the same-ish code in 3 places in genegraph, I'm trying to put together a parameterized script that can replace the long chain, and allow for maintaining the steps in a single place.Right now the script is specific for genegraph, but I'm wondering if it would be worth expanding it so that it can update helm values which are not helm specific.
See also clingen-data-model/genegraph#421