Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address #103 properties file simplification #105

Closed
wants to merge 2 commits into from
Closed

Conversation

seancorfield
Copy link
Contributor

This addresses the streamlining of the overridden properties to just those that need to be different.

This includes reverting the database location to the default (in the Maven cache).

This does not deprecate the -d option yet.

Signed-off-by: Sean Corfield [email protected]

including data.directory

Signed-off-by: Sean Corfield <[email protected]>
Signed-off-by: Sean Corfield <[email protected]>
@seancorfield
Copy link
Contributor Author

@lread Can you take a look at this and see if this looks sane? I wasn't sure how best to handle the deprecation of -d -- is that something that can be done within the new CLI lib you swapped in, or is that just a matter of documentation?

I forgot about the commit signing requirement -- I had to turn that off due to working with some stuff on Oracle Linux 8.8 locally -- so if this looks reasonable, I'll do a new PR with everything signed.

@seancorfield
Copy link
Contributor Author

Handled in #106 so closing this out.

@seancorfield seancorfield deleted the issue-103 branch August 19, 2024 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant