fixes #104 by supporting properties via environment variables #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sean Corfield <[email protected]>
Signed-off-by: Sean Corfield <[email protected]>
Signed-off-by: Sean Corfield <[email protected]>
|
@lread Feedback on adding support for env vars like this? |
seancorfield
commented
Aug 19, 2024
| (->> props (.mergeProperties settings)) | ||
| (->> props slurp .getBytes ByteArrayInputStream. (.mergeProperties settings)))) | ||
| (let [settings (Settings.) | ||
| props |
There was a problem hiding this comment.
The nested let was bothering me 🙂
lread
reviewed
Aug 19, 2024
Comment on lines
+40
to
+44
| (if p-value | ||
| (println (str "Ignoring " env-var " as " property " is already set.")) | ||
| (do | ||
| (println (str "Setting " property " from " env-var ".")) | ||
| (System/setProperty property value)))))) |
There was a problem hiding this comment.
I really like the feedback to the user here!
|
It looks succinct and clean to me @seancorfield! |
lread
added a commit
to lread/clj-watson
that referenced
this pull request
Aug 20, 2024
…-line-arg * upstream/main: address clj-holmes#103 Streamline dependency(-)check.properties overrides (clj-holmes#106) fixes clj-holmes#104 by supporting properties via environment variables (clj-holmes#108)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.