Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/remove datomic #10

Merged
merged 2 commits into from
Jan 26, 2020
Merged

Feature/remove datomic #10

merged 2 commits into from
Jan 26, 2020

Conversation

dazld
Copy link
Contributor

@dazld dazld commented Jan 26, 2020

  • Contributes to ClojureScript support #9
  • Remove runtime dependency on datomic-free
  • Keep it in for tests so we can keep asserting on actual, real entities.

@dazld
prefer sniffing entity-ishness to having a concrete datomic dependency
a5cbd76 
Entities _always_ have a `:db/id` property. In the case that a user has passed something with this key, and it’s not an Entity, we’re fine too, as we also don’t want to treat maps as sequences.
@dazld
move datomic-free dependency to test alias
442e0d7
@dazld dazld merged commit 8459652 into master Jan 26, 2020
@dazld dazld deleted the feature/remove-datomic branch January 26, 2020 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dazld