Skip to content

Commit

Permalink
Remove jdetter as codeowner for now (#1939)
Browse files Browse the repository at this point in the history 
Co-authored-by: John Detter <[email protected]>
  • Loading branch information
@jdetter
jdetter and John Detter authored Nov 5, 2024
1 parent f22b163 commit e94009a
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions .github/CODEOWNERS
View file
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
/crates/core/src/db/datastore/traits.rs @cloutiertyler
/rust-toolchain.toml @jdetter @cloutiertyler
/rust-toolchain.toml @cloutiertyler
/.github/CODEOWNERS @cloutiertyler
LICENSE.txt @cloutiertyler
/crates/client-api-messages/src/websocket.rs @centril @gefjon

/crates/cli/src/ @bfops @jdetter @cloutiertyler
/crates/cli/src/ @bfops @cloutiertyler
/crates/cli/src/subcommands/generate/ # No owners
/crates/cli/src/subcommands/generate/mod.rs @bfops @jdetter @cloutiertyler # These codeowners should be the same as the "root" CLI codeowners
/crates/cli/src/subcommands/generate/mod.rs @bfops @cloutiertyler # These codeowners should be the same as the "root" CLI codeowners

2 comments on commit e94009a

@github-actions
Copy link

@github-actions github-actions bot commented on e94009a Nov 5, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmarking failed. Please check the workflow run for details.

@github-actions
Copy link

@github-actions github-actions bot commented on e94009a Nov 5, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Callgrind benchmark results

Callgrind Benchmark Report

These benchmarks were run using callgrind,
an instruction-level profiler. They allow comparisons between sqlite (sqlite), SpacetimeDB running through a module (stdb_module), and the underlying SpacetimeDB data storage engine (stdb_raw). Callgrind emulates a CPU to collect the below estimates.

Measurement changes larger than five percent are in bold.

In-memory benchmarks

callgrind: empty transaction

db total reads + writes old total reads + writes Δrw estimated cycles old estimated cycles Δcycles
stdb_raw 6364 6364 0.00% 6460 6460 0.00%
sqlite 5579 5579 0.00% 5965 5965 0.00%

callgrind: filter

db schema indices count preload _column data_type total reads + writes old total reads + writes Δrw estimated cycles old estimated cycles Δcycles
stdb_raw u32_u64_str no_index 64 128 1 u64 76558 76558 0.00% 77058 77054 0.01%
stdb_raw u32_u64_str no_index 64 128 2 string 119056 119056 0.00% 119858 119806 0.04%
stdb_raw u32_u64_str btree_each_column 64 128 2 string 25052 25049 0.01% 25666 25643 0.09%
stdb_raw u32_u64_str btree_each_column 64 128 1 u64 24016 24016 0.00% 24432 24428 0.02%
sqlite u32_u64_str no_index 64 128 2 string 144695 144695 0.00% 146115 146115 0.00%
sqlite u32_u64_str no_index 64 128 1 u64 124050 124044 0.00% 125268 125266 0.00%
sqlite u32_u64_str btree_each_column 64 128 1 u64 131361 131361 0.00% 132803 132803 0.00%
sqlite u32_u64_str btree_each_column 64 128 2 string 134494 134494 0.00% 136178 136178 0.00%

callgrind: insert bulk

db schema indices count preload total reads + writes old total reads + writes Δrw estimated cycles old estimated cycles Δcycles
stdb_raw u32_u64_str unique_0 64 128 877856 878509 -0.07% 903210 903703 -0.05%
stdb_raw u32_u64_str btree_each_column 64 128 1028456 1033745 -0.51% 1093252 1099079 -0.53%
sqlite u32_u64_str unique_0 64 128 398320 398320 0.00% 414690 414686 0.00%
sqlite u32_u64_str btree_each_column 64 128 983637 983637 0.00% 1016423 1016419 0.00%

callgrind: iterate

db schema indices count total reads + writes old total reads + writes Δrw estimated cycles old estimated cycles Δcycles
stdb_raw u32_u64_str unique_0 1024 153691 153691 0.00% 153801 153801 0.00%
stdb_raw u32_u64_str unique_0 64 16716 16716 0.00% 16830 16806 0.14%
sqlite u32_u64_str unique_0 1024 1067255 1067255 0.00% 1070719 1070719 0.00%
sqlite u32_u64_str unique_0 64 76201 76201 0.00% 77315 77315 0.00%

callgrind: serialize_product_value

count format total reads + writes old total reads + writes Δrw estimated cycles old estimated cycles Δcycles
64 json 47528 47528 0.00% 50282 50282 0.00%
64 bsatn 25509 25509 0.00% 27753 27753 0.00%
16 bsatn 8200 8200 0.00% 9560 9560 0.00%
16 json 12188 12188 0.00% 14194 14194 0.00%

callgrind: update bulk

db schema indices count preload total reads + writes old total reads + writes Δrw estimated cycles old estimated cycles Δcycles
stdb_raw u32_u64_str unique_0 1024 1024 20519049 20516923 0.01% 21186229 21184329 0.01%
stdb_raw u32_u64_str unique_0 64 128 1287041 1287079 -0.00% 1332669 1333387 -0.05%
sqlite u32_u64_str unique_0 1024 1024 1802182 1802182 0.00% 1811454 1811454 0.00%
sqlite u32_u64_str unique_0 64 128 128528 128528 0.00% 131498 131498 0.00%
On-disk benchmarks

callgrind: empty transaction

db total reads + writes old total reads + writes Δrw estimated cycles old estimated cycles Δcycles
stdb_raw 6369 6369 0.00% 6473 6473 0.00%
sqlite 5621 5621 0.00% 6059 6059 0.00%

callgrind: filter

db schema indices count preload _column data_type total reads + writes old total reads + writes Δrw estimated cycles old estimated cycles Δcycles
stdb_raw u32_u64_str no_index 64 128 1 u64 76563 76563 0.00% 77031 77043 -0.02%
stdb_raw u32_u64_str no_index 64 128 2 string 119061 119061 0.00% 119859 119727 0.11%
stdb_raw u32_u64_str btree_each_column 64 128 2 string 25053 25053 0.00% 25575 25571 0.02%
stdb_raw u32_u64_str btree_each_column 64 128 1 u64 24021 24021 0.00% 24401 24401 0.00%
sqlite u32_u64_str no_index 64 128 1 u64 125965 125965 0.00% 127403 127403 0.00%
sqlite u32_u64_str no_index 64 128 2 string 146616 146616 0.00% 148288 148284 0.00%
sqlite u32_u64_str btree_each_column 64 128 2 string 136616 136616 0.00% 138714 138714 0.00%
sqlite u32_u64_str btree_each_column 64 128 1 u64 133457 133457 0.00% 135349 135349 0.00%

callgrind: insert bulk

db schema indices count preload total reads + writes old total reads + writes Δrw estimated cycles old estimated cycles Δcycles
stdb_raw u32_u64_str unique_0 64 128 826707 827017 -0.04% 851253 851473 -0.03%
stdb_raw u32_u64_str btree_each_column 64 128 978716 977688 0.11% 1042124 1041490 0.06%
sqlite u32_u64_str unique_0 64 128 415857 415857 0.00% 431645 431649 -0.00%
sqlite u32_u64_str btree_each_column 64 128 1021898 1021898 0.00% 1054012 1054012 0.00%

callgrind: iterate

db schema indices count total reads + writes old total reads + writes Δrw estimated cycles old estimated cycles Δcycles
stdb_raw u32_u64_str unique_0 1024 153696 153696 0.00% 153782 153782 0.00%
stdb_raw u32_u64_str unique_0 64 16721 16721 0.00% 16807 16807 0.00%
sqlite u32_u64_str unique_0 1024 1070323 1070323 0.00% 1074085 1074085 0.00%
sqlite u32_u64_str unique_0 64 77973 77973 0.00% 79303 79303 0.00%

callgrind: serialize_product_value

count format total reads + writes old total reads + writes Δrw estimated cycles old estimated cycles Δcycles
64 json 47528 47528 0.00% 50282 50282 0.00%
64 bsatn 25509 25509 0.00% 27753 27753 0.00%
16 bsatn 8200 8200 0.00% 9560 9560 0.00%
16 json 12188 12188 0.00% 14194 14194 0.00%

callgrind: update bulk

db schema indices count preload total reads + writes old total reads + writes Δrw estimated cycles old estimated cycles Δcycles
stdb_raw u32_u64_str unique_0 1024 1024 19036556 19039824 -0.02% 19739060 19740930 -0.01%
stdb_raw u32_u64_str unique_0 64 128 1240282 1239971 0.03% 1314914 1315503 -0.04%
sqlite u32_u64_str unique_0 1024 1024 1809743 1809743 0.00% 1818367 1818367 0.00%
sqlite u32_u64_str unique_0 64 128 132654 132654 0.00% 135668 135668 0.00%

Please sign in to comment.