Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Mazdak Farrokhzad <[email protected]>
Signed-off-by: Mario Montoya <[email protected]>
  • Loading branch information
mamcx and Centril authored Dec 12, 2024
1 parent 0796849 commit ea1c16f
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -648,7 +648,6 @@ impl CommittedState {

pub struct CommittedIndexIterTx<'a> {
committed_rows: IndexScanIter<'a>,
num_committed_rows_fetched: u64,
}

impl<'a> CommittedIndexIterTx<'a> {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -170,12 +170,10 @@ impl<'a> IterMutTx<'a> {
.get(&table_id)
.map(|table| (table, &tx_state.blob_store));

let tx_state_del = tx_state.delete_tables.get(&table_id);

let stage = if let Some(table) = committed_state.tables.get(&table_id) {
// The committed state has changes for this table.
let iter = table.scan_rows(&committed_state.blob_store);
if let Some(del_tables) = tx_state_del.and_then(|del| if del.is_empty() { None } else { Some(del) }) {
if let Some(del_tables) = tx_state.delete_tables.get(&table_id).filter(|del| !del.is_empty()) {
// There are deletes in the tx state
// so we must exclude those (1b).
ScanStage::CommittedWithTxDeletes { iter, del_tables }
Expand Down
2 changes: 1 addition & 1 deletion crates/core/src/vm.rs
Original file line number Diff line number Diff line change
Expand Up @@ -367,7 +367,7 @@ static_assert_size!(
/// An index join operator that returns matching rows from the probe side.
pub struct IndexSemiJoinRight<'c, Rhs: RelOps<'c>, F> {
/// An iterator for the probe side.
/// The values returned will be useSd to probe the index.
/// The values returned will be used to probe the index.
probe_side: Rhs,
/// The column whose value will be used to probe the index.
probe_col: ColId,
Expand Down

0 comments on commit ea1c16f

Please sign in to comment.