Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[STABILITY] Migrate db log paths(waiting folder proposal) #1423

Closed
wants to merge 1 commit into from

Conversation

mamcx
Copy link
Contributor

@mamcx mamcx commented Jun 13, 2024

Description of Changes

Closes #581

Stores module logs in $STDB_PATH/database_instances

API and ABI breaking changes

If this is an API or ABI breaking change, please apply the
corresponding GitHub label.

Expected complexity level and risk

1

Testing

Describe any testing you've done, and any testing you'd like your reviewers to do,
so that you're confident that all the changes work as expected!

  • Manually inspect the logs created in the correct path.

@mamcx mamcx requested a review from kim June 13, 2024 16:55
@mamcx mamcx self-assigned this Jun 13, 2024
@kim
Copy link
Contributor

kim commented Jun 13, 2024

The full context got lost it seems: the distinction control_node / worker_node still exists in standalone.

We can either:

  • store things in worker_node even if it does not make a lot of sense, or
  • determine the instances root by a parametrized function relative to STDB_ROOT

I’m more in favor of the latter, so as to not have hardcoded stdb_path(“some/path”) all over the place.

@mamcx
Copy link
Contributor Author

mamcx commented Jun 13, 2024

Ok, so I need to differentiate by edition?

@kim
Copy link
Contributor

kim commented Jun 14, 2024

I would propose to simply retire the worker_node directory. We would then have:

STDB_PATH
| -- conf
| -- config.toml
| -- logs
| -- database_instances
|     `-- <address>
|           `-- <instance_id>
|                 | -- database
|                 | -- module_logs
|                 `-- scheduler 
`-- wasmtime_cache

Standalone can keep using control_node then.

@mamcx mamcx added no runtime change This change does not affect the final binaries api-break release-0.10 labels Jun 14, 2024
@joshua-spacetime joshua-spacetime changed the title Migrate db log paths [STABILITY] Migrate db log paths(waiting folder proposal) Jul 8, 2024
@bfops bfops removed no runtime change This change does not affect the final binaries release-0.10 labels Jul 22, 2024
@mamcx
Copy link
Contributor Author

mamcx commented Sep 19, 2024

Closed, will be made by #1657

@mamcx mamcx closed this Sep 19, 2024
@bfops bfops added the api-break A PR that makes an API breaking change label Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-break A PR that makes an API breaking change release-1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants