Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More obsolete cleanup #1782

Merged
merged 4 commits into from
Oct 1, 2024
Merged

More obsolete cleanup #1782

merged 4 commits into from
Oct 1, 2024

Conversation

RReverser
Copy link
Contributor

Description of Changes

Cleanup leftovers of the query macro & mark obsolete C# ABIs as such.

API and ABI breaking changes

If this is an API or ABI breaking change, please apply the
corresponding GitHub label.

Expected complexity level and risk

How complicated do you think these changes are? Grade on a scale from 1 to 5,
where 1 is a trivial change, and 5 is a deep-reaching and complex change.

This complexity rating applies not only to the complexity apparent in the diff,
but also to its interactions with existing and future code.

If you answered more than a 2, explain what is complex about the PR,
and what other components it interacts with in potentially concerning ways.

Testing

Describe any testing you've done, and any testing you'd like your reviewers to do,
so that you're confident that all the changes work as expected!

  • Write a test you've completed here.
  • Write a test you want a reviewer to do here, so they can check it off when they're satisfied.

Copy link
Contributor

@cloutiertyler cloutiertyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am approve this. For context for future readers, we're marking this Obsolete but they actually don't work at all since #1777
because the underlying abi function have been removed. This will be resolved when these functions are removed entirely in #1707

@RReverser RReverser added this pull request to the merge queue Oct 1, 2024
@RReverser RReverser removed this pull request from the merge queue due to a manual request Oct 1, 2024
@RReverser RReverser enabled auto-merge October 1, 2024 19:42
@RReverser RReverser disabled auto-merge October 1, 2024 19:45
@RReverser RReverser enabled auto-merge October 1, 2024 19:47
@RReverser RReverser added this pull request to the merge queue Oct 1, 2024
Merged via the queue into master with commit d081e4a Oct 1, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants