Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add /health endpoint #1989

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add /health endpoint #1989

wants to merge 2 commits into from

Conversation

drogus
Copy link
Collaborator

@drogus drogus commented Nov 12, 2024

Description of Changes

This PR adds a health endpoint with some potentailly usefeul information like:

  • package name (so we can distinguish between standalone and cloud)
  • package version
  • if the current node is schedulable
  • a list of nodes in the cluster

API and ABI breaking changes

No breakage, the endpoint didn't exist in standalone before.

Expected complexity level and risk

1

Testing

  • Local test
  • Start the server, check if the /health endpoint responds with 200

Copy link
Collaborator

@kurtismullins kurtismullins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me but I don't know enough about our internal system (e.g get_nodes()) to be a good reviewer of this.

I think that as long as it actually represents the database being healthy, its better than what we have now!

@bfops bfops added the release-any To be landed in any release window label Dec 2, 2024
@drogus drogus enabled auto-merge December 16, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-any To be landed in any release window
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants