Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

query rewriter #2031

Merged
merged 1 commit into from
Dec 12, 2024
Merged

query rewriter #2031

merged 1 commit into from
Dec 12, 2024

Conversation

joshua-spacetime
Copy link
Collaborator

First batch of query rewrite rules optimizing index joins

@bfops bfops added the release-any To be landed in any release window label Dec 2, 2024
crates/physical-plan/src/plan.rs Outdated Show resolved Hide resolved
crates/physical-plan/src/plan.rs Outdated Show resolved Hide resolved
crates/physical-plan/src/plan.rs Outdated Show resolved Hide resolved
crates/physical-plan/src/plan.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@mamcx mamcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just fix the test...

@joshua-spacetime joshua-spacetime force-pushed the joshua/perf/rewrite branch 2 times, most recently from bb9dee9 to 3c53826 Compare December 5, 2024 20:17
Copy link
Contributor

@mamcx mamcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The comments will be in another pr as discussed...

crates/expr/src/check.rs Outdated Show resolved Hide resolved
@joshua-spacetime joshua-spacetime force-pushed the joshua/perf/rewrite branch 4 times, most recently from cb054eb to caec982 Compare December 12, 2024 21:05
@joshua-spacetime joshua-spacetime changed the title query rewrite rules query rewriter Dec 12, 2024
@joshua-spacetime joshua-spacetime added this pull request to the merge queue Dec 12, 2024
Merged via the queue into master with commit 9211708 Dec 12, 2024
9 checks passed
@joshua-spacetime joshua-spacetime deleted the joshua/perf/rewrite branch December 12, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-any To be landed in any release window
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants