Migrate C# client-side reducer enum to the new syntax #2033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RReverser
force-pushed
the
ingvar/client-reducer-enum
branch
2 times, most recently
from
8e69576 to
3970543
Compare
As per clockworklabs/SpacetimeDBPrivate#1198. This makes reducers use the same codegen structure as tables and other tuple types, but nests them inside a `Reducer` class as subclasses for pattern-matching, like we allow on tagged enums. The reason we don't use a tagged enum here anymore is because we don't need BSATN sum type support for the Reducer enum, and it imposes unnecessary restrictions like max 256 elements.
RReverser
force-pushed
the
ingvar/client-reducer-enum
branch
from
3f5a30c to
cbe8de0
Compare
gefjon
approved these changes
Dec 4, 2024
crates/bindings-csharp/Runtime/Internal/Autogen/RawRowLevelSecurityDefV9.cs
Show resolved
Hide resolved
bfops
approved these changes
Dec 4, 2024
RReverser
added a commit
to clockworklabs/com.clockworklabs.spacetimedbsdk
that referenced
this pull request
Dec 4, 2024
Counterpart to clockworklabs/SpacetimeDB#2033. Also updated test settings to make sure that sum type variants implemented via subclassing are shown as expected.
2 tasks
RReverser
added a commit
to clockworklabs/com.clockworklabs.spacetimedbsdk
that referenced
this pull request
Dec 4, 2024
Counterpart to clockworklabs/SpacetimeDB#2033. Also updated test settings to make sure that sum type variants implemented via subclassing are shown as expected.
RReverser
added a commit
to clockworklabs/com.clockworklabs.spacetimedbsdk
that referenced
this pull request
Dec 4, 2024
Counterpart to clockworklabs/SpacetimeDB#2033. Also updated test settings to make sure that sum type variants implemented via subclassing are shown as expected.
bfops
pushed a commit
that referenced
this pull request
Dec 6, 2024
RReverser
added a commit
to clockworklabs/com.clockworklabs.spacetimedbsdk
that referenced
this pull request
Dec 11, 2024
Counterpart to clockworklabs/SpacetimeDB#2033. Also updated test settings to make sure that sum type variants implemented via subclassing are shown as expected.
RReverser
added a commit
to clockworklabs/com.clockworklabs.spacetimedbsdk
that referenced
this pull request
Dec 11, 2024
Counterpart to clockworklabs/SpacetimeDB#2033. Also updated test settings to make sure that sum type variants implemented via subclassing are shown as expected.
RReverser
added a commit
to clockworklabs/com.clockworklabs.spacetimedbsdk
that referenced
this pull request
Dec 11, 2024
Counterpart to clockworklabs/SpacetimeDB#2033. Also updated test settings to make sure that sum type variants implemented via subclassing are shown as expected.
RReverser
added a commit
to clockworklabs/com.clockworklabs.spacetimedbsdk
that referenced
this pull request
Dec 11, 2024
Counterpart to clockworklabs/SpacetimeDB#2033. Also updated test settings to make sure that sum type variants implemented via subclassing are shown as expected.
cloutiertyler
pushed a commit
to clockworklabs/com.clockworklabs.spacetimedbsdk
that referenced
this pull request
Dec 12, 2024
## Description of Changes Counterpart to clockworklabs/SpacetimeDB#2033. Also updated test settings to make sure that sum type variants implemented via subclassing are shown as expected. ## API - [ ] This is an API breaking change to the SDK *If the API is breaking, please state below what will break* ## Requires SpacetimeDB PRs *List any PRs here that are required for this SDK change to work* ## Testsuite *If you would like to run against a specific SpacetimeDB branch in the testsuite, specify that here. This can be a branch name or a link to a PR.* SpacetimeDB branch name: master ## Testing *Write instructions for a test that you performed for this PR* - [ ] Describe a test for this PR that you have completed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
As per https://github.com/clockworklabs/SpacetimeDBPrivate/pull/1198.
This makes reducers use the same codegen structure as tables and other tuple types, but nests them inside a
Reducerclass as subclasses for pattern-matching, like we allow on tagged enums.The reason we don't use a tagged enum here anymore is because we don't need BSATN sum type support for the Reducer enum, and it imposes unnecessary restrictions like max 256 elements.
While testing the changes, simplified the C# CI a bit by reusing the
tools~/write-nuget-config.shscript from the C# SDK repo instead of duplicating its logic.API and ABI breaking changes
API breaking change for the client.
Expected complexity level and risk
2 - a breaking change, but shouldn't affect too much client code.
Testing
Waiting for CI to test it against client SDK, it's a bit quicker than manual.