move unique constraint checking until after optimistic insertion #2037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's the deal with all the test failures? |
Centril
force-pushed
the
centril/late-constraint-checking
branch
from
1eebec1 to
1d4d126
Compare
Seems one file ended up in the stash that shouldn't have. |
|
Can you bring in latest master to fix the "Internal Tests" job? |
Centril
force-pushed
the
centril/late-constraint-checking
branch
from
1d4d126 to
57fd564
Compare
Yep, done. |
Centril
force-pushed
the
centril/late-constraint-checking
branch
from
57fd564 to
f45b027
Compare
gefjon
reviewed
Dec 5, 2024
Centril
force-pushed
the
centril/late-constraint-checking
branch
3 times, most recently
from
d15faf7 to
459601f
Compare
Centril
force-pushed
the
centril/late-constraint-checking
branch
from
459601f to
46094e0
Compare
gefjon
approved these changes
Dec 5, 2024
Centril
force-pushed
the
centril/late-constraint-checking
branch
from
11391fe to
c3f304a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Move unique constraint checking until after the row has been inserted and roll back if there was a violation.
We need to do this to enable insertion via BSATN as we no longer will have a PV.
After insertion, we can instead project
RowRefs to the index types.This should also facilitate moving indices out of tables.
Testing
Proptests are amended to reflect new order.