datastore: insert via BSATN instead of via PV #2069
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Centril
force-pushed
the
centril/insert-bsatn
branch
2 times, most recently
from
501e360 to
5df3305
Compare
Centril
force-pushed
the
centril/insert-bsatn
branch
from
5df3305 to
5dfebdd
Compare
Centril
commented
Dec 18, 2024
| // and the encoded length to `row_len`. | ||
| let counter = CountWriter::default(); | ||
| let mut writer = TeeWriter::new(counter, buffer); | ||
| bsatn::to_writer(&mut writer, &gen_cols).unwrap(); |
There was a problem hiding this comment.
Note to self: this is wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
This PR changes the structure of the datastore to insert via BSATN rather than a PV. But this isn't entirely true, we just use the fast-path for BSATN -> BFLATN but in the general case we still do BSATN -> PV -> BFLATN. Later, I'll fully remove the temporary step. One of the other required changes here is that we write and generate sequence values directly in BFLATN.
Fixes #2017.
API and ABI breaking changes
None
Expected complexity level and risk
4 -- limited scope, but lots of unsafe code and complicated logic.