Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: qualified projection columns #2070

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

joshua-spacetime
Copy link
Collaborator

Description of Changes

The parser qualifies all names. Any names that remain unqualified is a parsing error.

API and ABI breaking changes

n/a

Expected complexity level and risk

1

Testing

Added applicable unit test to the parser

@joshua-spacetime joshua-spacetime self-assigned this Dec 18, 2024
Copy link
Contributor

@mamcx mamcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshua-spacetime joshua-spacetime added this pull request to the merge queue Dec 19, 2024
Merged via the queue into master with commit 10598ba Dec 19, 2024
9 checks passed
@joshua-spacetime joshua-spacetime deleted the joshua/fix/qualified-names branch December 19, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants