Query execution updates for cpu metrics #2130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshua-spacetime
force-pushed
the
joshua/materialized-query-execution
branch
2 times, most recently
from
89276dc to
bc1fcdc
Compare
joshua-spacetime
force-pushed
the
joshua/materialized-query-execution
branch
from
bc1fcdc to
816f481
Compare
joshua-spacetime
force-pushed
the
joshua/materialized-query-execution
branch
from
816f481 to
8a36603
Compare
joshua-spacetime
force-pushed
the
joshua/materialized-query-execution
branch
2 times, most recently
from
c33250b to
22af59b
Compare
joshua-spacetime
changed the title
joshua-spacetime
removed this pull request from the merge queue due to a manual request
Fully evaluates each operator before evaluating downstream ones. This is in contrast to a tuple at a time iterator, where each row is fully processed by all operators, before processing the next row. It is called "materializing" because each operator materializes its output. In practice however, non-blocking operators will be pipelined, so as not to perform unnecessary materialization.
joshua-spacetime
force-pushed
the
joshua/materialized-query-execution
branch
from
5ebb2c6 to
cc4f397
Compare
joshua-spacetime
changed the title
joshua-spacetime
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
This patch is a prerequisite for computing query cpu metrics.
Tuple at a time iterators are not well suited to gathering per operator metrics.
API and ABI breaking changes
None
Expected complexity level and risk
2
Adding new query executors is relatively straightforward since they work off of the same physical plan. We can rely on our current test coverage to catch any issues.
Testing
Describe any testing you've done, and any testing you'd like your reviewers to do,
so that you're confident that all the changes work as expected!
No new tests have been added. We already have correctness tests for the query and subscription code that are executor agnostic.