Cache whether a Table
is a scheduler table, avoiding fetching the schema
#2141
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Fixes #2021.
Does 2 things:
fn update_mut_tx
totraits.rs
Table::is_scheduler
sodatastore_{insert, update}_bsatn
don't have to fetch the schema.Perf before:
Perf after:
This means we go from an average 610 ms to 585 ms, which is about an average 25 ms speedup.
This was the expected speedup based on % of samples in the update ABI PR flamegraph.
API and ABI breaking changes
None
Expected complexity level and risk
1, fairly simple and contained change.
Testing
TODO