Set tracing static level for binaries only
#2144
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disabling tracing (`features = ["release_max_level_off"]`) at the workspace level prevents library users from using tracing at all. Instead, set the feature for each binary individually. Also change all but one `#[instrument]` macros to be at "trace" level, which will prevent code gen unless the static level is at trace. This is because most of them were introduced for `tracy` tracing, and may be at "hot" code locations. Fixes: #2117
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disabling tracing (
features = ["release_max_level_off"]) at theworkspace level prevents library users from using tracing at all.
Instead, set the feature for each binary individually.
Also change all but one
#[instrument]macros to be at "trace" level,which will prevent code gen unless the static level is at trace. This is
because most of them were introduced for
tracytracing, and may be at"hot" code locations.
Fixes: #2117
Expected complexity level and risk
1
Testing
Build the proprietary edition with this patch and confirm logs emitted via the
tracingcrate's macros are output. Both from public and proprietary code.